Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTALL.Unix: update libmozjs install tips #5107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alxndrsn
Copy link
Contributor

Older versions of libmozjs-dev may not be available to install from package repos, and newer versions may work fine.

Older versions of libmozjs-dev may not be available to install from package repos, and newer versions may work fine.
@big-r81
Copy link
Contributor

big-r81 commented Jun 29, 2024

@alxndrsn Thanks for the update. The latest supported version of Spidermonkey is v91.

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Jun 29, 2024

@alxndrsn Thanks for the update. The latest supported version of Spidermonkey is v91.

Would a better change therefore be:

Your distribution may have `libmozjs-68-dev` or `libmozjs-91-dev` instead of 60. All are supported.

?

@@ -66,7 +66,7 @@ You can install the dependencies by running:
build-essential pkg-config erlang erlang-reltool \
libicu-dev libmozjs-60-dev python3

Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported.
Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported. Newer versions of `libmozjs-...-dev` may also work; you can find which are available using `apt-cache search libmozjs`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest mention Newer versions less or equal to 91 of libmozjs... just to be a bit more explicit.

@@ -66,7 +66,7 @@ You can install the dependencies by running:
build-essential pkg-config erlang erlang-reltool \
libicu-dev libmozjs-60-dev python3

Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported.
Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported. Newer versions of `libmozjs-...-dev` may also work; you can find which are available using `apt-cache search libmozjs`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest this, which is i think a bit more comprehensive approach.
Your distribution might provide libmozjs-68-dev instead of libmozjs-60-dev, and both are supported. Additionally, newer versions of libmozjs-...-dev may also be compatible. To see which versions are available, use the command "apt-cache search libmozjs"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants